Skip to content

Fixed the source-rss connector path - preventing it from adding trail… #69828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed the source-rss connector path - preventing it from adding trail… #69828

wants to merge 1 commit into from
+1 −1

Conversation

@syspect-sec
Copy link

@syspect-sec syspect-sec commented Nov 23, 2025

What

Fixed the source-rss connector path - preventing it from adding trailing '/' unnecessarily
This issue has been recognized for over one year, and an invitation was made in Issue 45389 for the "community" to identify the issue and offer a solution.

This problem is exemplified by an RSS URL such as:

When the source-rss connector automatically appends a / at the end (https://www.cyber.gc.ca/api/cccs/atom/v1/get?feed=alerts_advisories/), it returns a failed status:

<feed xml:lang="en">
<id>https://cyber.gc.ca/&lang=en</id>
<link rel="self" href="https://cyber.gc.ca/&lang=en"/>
<title>404 - ERROR</title>
<updated/>
</feed>

The user should be able to enter the correct URL and it should be used without modification.

How

modified the manifest.yaml file to change path: "/" to path: "".

User Impact

The end result is that the Airbyte installation will import RSS feeds properly out of the box.

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2025

👋 Welcome to Airbyte!

Thank you for your contribution from syspect-sec/airbyte! We're excited to have you in the Airbyte community.

Helpful Resources

PR Slash Commands

As needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
  • /run-connector-tests - Runs connector tests.
  • /run-cat-tests - Runs CAT tests.
  • /run-live-tests - Runs live tests for the modified connector(s).
  • /run-regression-tests - Runs regression tests for the modified connector(s).
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).

If you have any questions, feel free to ask in the PR comments or join our Slack community.

Tips for Working with CI

  1. Pre-Release Checks. Please pay attention to these, as they contain standard checks on the metadata.yaml file, docs requirements, etc. If you need help resolving a pre-release check, please ask a maintainer.
    • Note: If you are creating a new connector, please be sure to replace the default logo.svg file with a suitable icon.
  2. Connector CI Tests. Some failures here may be expected if your tests require credentials. Please review these results to ensure (1) unit tests are passing, if applicable, and (2) integration tests pass to the degree possible and expected.
  3. (Optional.) BYO Connector Credentials for tests in your fork. You can optionally set up your fork with BYO credentials for your connector. This can significantly speed up your review, ensuring your changes are fully tested before the maintainers begin their review.

📝 Edit this welcome message.

@syspect-sec syspect-sec mentioned this pull request Nov 23, 2025
Closed
1 task
@DanyloGL
Copy link
Collaborator

DanyloGL commented Nov 24, 2025

@syspect-sec thank you for your contribution!
Could you please increase dockerImageTag in metadata.yaml file and update changelog section in docs file?

@DanyloGL
Copy link
Collaborator

DanyloGL commented Nov 24, 2025 •
edited by github-actions bot
Loading

/run-connector-tests

Connector CI Tests Started

These tests will leverage Airbyte's integration test credentials.

Check job output.
✅ Connector CI Tests job completed successfully. See logs for details.

@DanyloGL DanyloGL moved this from New PRs to Waiting Eng Team in 🧑‍🏭 Community Pull Requests Nov 24, 2025
@DanyloGL DanyloGL moved this from Waiting Eng Team to Waiting Contributor in 🧑‍🏭 Community Pull Requests Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

community connectors/source/rss

Projects

🧑‍🏭 Community Pull Requests
Status: Waiting Contributor

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@syspect-sec @CLAassistant @DanyloGL @octavia-squidington-iii